Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934801AbYBGVo6 (ORCPT ); Thu, 7 Feb 2008 16:44:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757944AbYBGVor (ORCPT ); Thu, 7 Feb 2008 16:44:47 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:37397 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757395AbYBGVoq (ORCPT ); Thu, 7 Feb 2008 16:44:46 -0500 Date: Thu, 7 Feb 2008 13:44:41 -0800 From: Andrew Morton To: "Clem Taylor" Cc: ulissesf@gmail.com, linux-kernel@vger.kernel.org, amy.griffis@hp.com Subject: Re: inotify_add_watch() returning ENOSPC in 2.6.24 [watch descriptor leak?] Message-Id: <20080207134441.00a4cd33.akpm@linux-foundation.org> In-Reply-To: References: <20080206015103.9a0f4069.akpm@linux-foundation.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 18 On Thu, 7 Feb 2008 16:24:15 -0500 "Clem Taylor" wrote: > On Feb 7, 2008 1:54 PM, Ulisses Furquim wrote: > > Ok, I had a go with it and found the problem. We weren't releasing > > one-shot watches because the test for them was wrong. We're using the > > event's mask to test for one-shot watches when we should've been using > > the watch's mask. > > Thanks, this patch seems to fix the problem. > Awesome. Thanks, guys. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/