Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932433AbYBGXfH (ORCPT ); Thu, 7 Feb 2008 18:35:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757221AbYBGXew (ORCPT ); Thu, 7 Feb 2008 18:34:52 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:45766 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755984AbYBGXev (ORCPT ); Thu, 7 Feb 2008 18:34:51 -0500 Date: Fri, 8 Feb 2008 00:35:09 +0100 From: Pavel Machek To: "Rafael J. Wysocki" Cc: "H. Peter Anvin" , kernel list , Linux-pm mailing list Subject: Re: [rft] s2ram wakeup moves to .c, could fix few machines Message-ID: <20080207233509.GB21468@elf.ucw.cz> References: <20080205190600.GB11613@elf.ucw.cz> <200802072312.31430.rjw@sisk.pl> <47AB887E.7010000@zytor.com> <200802080006.54151.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200802080006.54151.rjw@sisk.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 34 Hi! > > > - memcpy((void *)acpi_wakeup_address, &wakeup_start, > > > - &wakeup_end - &wakeup_start); > > > - acpi_copy_wakeup_routine(acpi_wakeup_address); > > > + memcpy((void *)acpi_realmode, &wakeup_code_start, 4*PAGE_SIZE); > > > > Using a PAGE_SIZE multiplier here isn't a good thing... > > Yes, I'll fix that in one of the next iterations. Agreed. > > > + header = (struct wakeup_header *)(acpi_realmode + 0x3f00); > > > > ... especially not with magic constants like this. > > Yeah. Pavel, what's at 0x3f00, btw? struct wakeup_header. I really need the entry point to be at offset 0, so that I can get pointers to my data. I could not figure out how to do it any other way. And if 0 is taken, I thought I'd put header at the end. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/