Message-ID: <47AC0E25.1060603@openvz.org>
Date: Fri, 08 Feb 2008 11:09:09 +0300
From: Pavel Emelyanov <xemul@openvz.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20071031)
MIME-Version: 1.0
To: Paul Menage <menage@google.com>
CC: Andrew Morton <akpm@linux-foundation.org>,
       Linux Containers <containers@lists.osdl.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][DOCUMENTATION] Minimal controller code for a quick start
References: <47AB25AD.30400@openvz.org> <6599ad830802071245r321efddat89a17b091cb5db4b@mail.gmail.com>
In-Reply-To: <6599ad830802071245r321efddat89a17b091cb5db4b@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2479
Lines: 82

Paul Menage wrote:
> On Feb 7, 2008 7:37 AM, Pavel Emelyanov <xemul@openvz.org> wrote:
>> The Documentation/cgroups.txt file contains the info on how
>> to write some controller for cgroups subsystem, but even with
>> this, one need to write quite a lot of code before developing
>> the core (or copy-n-paste it from some other place).
> 
> Good idea.
> 
>> +
>> +static ssize_t foo_bar_read(struct cgroup *cg, struct cftype *cft,
>> +               struct file *file, char __user *userbuf,
>> +               size_t nbytes, loff_t *ppos)
>> +{
>> +       struct foo_cgroup *foo;
>> +
>> +       foo = foo_from_cgroup(cg);
>> +
>> +       /*
>> +        * produce some output
>> +        */
>> +
>> +       return nbytes;
>> +}
>> +
>> +static ssize_t foo_bar_write(struct cgroup *cg, struct cftype *cft,
>> +               struct file *file, const char __user *userbuf,
>> +               size_t nbytes, loff_t *ppos)
>> +{
>> +       struct foo_cgroup *foo;
>> +
>> +       foo = foo_from_cgroup(cg);
>> +
>> +       /*
>> +        * read and tune the foo
>> +        */
>> +
>> +       return nbytes;
>> +}
>> +
>> +static struct cftype foo_files[] = {
>> +       {
>> +               .name = "bar",
>> +               .read = foo_bar_read,
>> +               .write = foo_bar_write,
>> +       },
>> +};
> 
> Can you structure this example so as to encourage people to use the
> more formatted read/write routines, such as read_int64 and
> write_int64?

And one more for ->read_strategy hints :) Well, I thought that
it should be the _minimal_ controller.

>> +
>> +static struct cgroup_subsys_state *foo_create(struct cgroup_subsys *cs,
>> +               struct cgroup *cg)
>> +{
>> +       struct foo_cgroup *foo;
>> +
> 
> Maybe add a comment here that mentions that if your cgroup needs very
> early initialization, you can check for cg->parent being NULL, and
> return a statically-constructed structure here. (And set
> foo_subsys.early_init = 1)

Yet again - this is rather a special feature, that your controller
needs an early initialization - for a very minimal one this is not
required.

Maybe we can have two examples? One is the minimal one and the other
is an advanced one with ->attach callbacks, etc?

> Paul
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/