Date: Fri, 8 Feb 2008 09:45:38 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
       Marcin Juszkiewicz <openembedded@haerwu.biz>,
       Christoph Hellwig <hch@infradead.org>, Greg KH <greg@kroah.com>,
       linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture
Message-ID: <20080208094538.GC21852@flint.arm.linux.org.uk>
References: <20080207133805.13f092ff@dilbert.local> <20080207125824.GB7111@infradead.org> <20080207130117.GA18750@uranus.ravnborg.org> <200802071609.36960.openembedded@haerwu.biz> <20080207160557.GB28435@flint.arm.linux.org.uk> <20080207202329.GA21949@uranus.ravnborg.org> <1202461453.5469.217.camel@pmac.infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1202461453.5469.217.camel@pmac.infradead.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 23

On Fri, Feb 08, 2008 at 09:04:13AM +0000, David Woodhouse wrote:
> On Thu, 2008-02-07 at 21:23 +0100, Sam Ravnborg wrote:
> > Both situations are trivially fixable by introducing
> > HAVE_IDE and HAVE_MTD.
> > See attached patch.
> 
> HAVE_MTD is wrong.

If we are serious about allowing ARM to use drivers/Kconfig, then let's
not get distracted by perfection - by trying to do too many changes in
one go.

If, today, we conditionalise MTD or IDE on a certain set of symbols,
then those conditions should be preserved in the first step - it should
be a 1:1 translation.

Later, if there's a need to improve it (as you're suggesting) that should
be a *separate* change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/