Subject: Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM
	architecture
From: David Woodhouse <dwmw2@infradead.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Sam Ravnborg <sam@ravnborg.org>,
       Marcin Juszkiewicz <openembedded@haerwu.biz>,
       Christoph Hellwig <hch@infradead.org>, Greg KH <greg@kroah.com>,
       linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org
In-Reply-To: <20080208094538.GC21852@flint.arm.linux.org.uk>
References: <20080207133805.13f092ff@dilbert.local>
	 <20080207125824.GB7111@infradead.org>
	 <20080207130117.GA18750@uranus.ravnborg.org>
	 <200802071609.36960.openembedded@haerwu.biz>
	 <20080207160557.GB28435@flint.arm.linux.org.uk>
	 <20080207202329.GA21949@uranus.ravnborg.org>
	 <1202461453.5469.217.camel@pmac.infradead.org>
	 <20080208094538.GC21852@flint.arm.linux.org.uk>
Content-Type: text/plain
Date: Fri, 08 Feb 2008 10:18:31 +0000
Message-Id: <1202465911.5469.240.camel@pmac.infradead.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1259
Lines: 35


On Fri, 2008-02-08 at 09:45 +0000, Russell King - ARM Linux wrote:
> If we are serious about allowing ARM to use drivers/Kconfig, then let's
> not get distracted by perfection - by trying to do too many changes in
> one go.
> 
> If, today, we conditionalise MTD or IDE on a certain set of symbols,
> then those conditions should be preserved in the first step - it should
> be a 1:1 translation.

That makes some sense. Currently you have:

	if ALIGNMENT_TRAP || !CPU_CP15_MMU
	source "drivers/mtd/Kconfig"
	endif

> Later, if there's a need to improve it (as you're suggesting) that should
> be a *separate* change.

We can certainly improve the behaviour later, it's true -- it's not the
end of the world if we continue to have the whole of the MTD layer
turned off on platforms with alignment problems for now.

But still, it's HAVE_UNALIGNED_ACCESS which we want to depend on, not a
newly-invented HAVE_MTD. And there are other places we really ought to
be depending on HAVE_UNALIGNED_ACCESS too.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/