Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964878AbYBHL1W (ORCPT ); Fri, 8 Feb 2008 06:27:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760264AbYBHL1N (ORCPT ); Fri, 8 Feb 2008 06:27:13 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:60529 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760114AbYBHL1M (ORCPT ); Fri, 8 Feb 2008 06:27:12 -0500 Date: Fri, 8 Feb 2008 11:27:09 +0000 From: Mark Brown To: Dmitry Torokhov Cc: linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Liam Girdwood , Graeme Gregory , Rodolfo Giometti , Russell King , Marc Kleine-Budde , Ian Molton , Vincent Sanders , Andrew Zabolotny Subject: Re: [PATCH 1/6] Core driver for WM97xx touchscreens Message-ID: <20080208112709.GA12028@rakim.wolfsonmicro.main> Mail-Followup-To: Dmitry Torokhov , linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Liam Girdwood , Graeme Gregory , Rodolfo Giometti , Russell King , Marc Kleine-Budde , Ian Molton , Vincent Sanders , Andrew Zabolotny References: <20080126151820.GA13899@sirena.org.uk> <1201368516-3513-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20080207170112.ZZRA012@mailhub.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080207170112.ZZRA012@mailhub.coreip.homeip.net> X-Cookie: BOFH excuse User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 18 On Thu, Feb 07, 2008 at 05:07:23PM -0500, Dmitry Torokhov wrote: > The probe error handling is not quite correct. When we reach the fragment > above ret variable is 0 so if platfrom_device_alloc() fails we will return > 0 and the device will be considered bound but in half-dead state. Please > make sure that proper error is returned in all cases. Also please do not > mix out of line and in-line error unwinding (input_free_device() should > be called in the error path and if you are concerned about double-free > after input_unregister_device() just set wm->input_dev to NULL there). Thanks for the review, I've implemented these changes and will resubmit as a followup to this e-mail, also including a change from Dmitry Baryshkov to make the devices unnumbered. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/