Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758729AbYBHNq5 (ORCPT ); Fri, 8 Feb 2008 08:46:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753656AbYBHNqt (ORCPT ); Fri, 8 Feb 2008 08:46:49 -0500 Received: from smtp6.pp.htv.fi ([213.243.153.40]:51142 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753388AbYBHNqs (ORCPT ); Fri, 8 Feb 2008 08:46:48 -0500 Date: Fri, 8 Feb 2008 15:30:22 +0200 From: Adrian Bunk To: Kamalesh Babulal Cc: rusty@rustcorp.com.au, LKML , linux-input@vger.kernel.org, Andy Whitcroft , Balbir Singh , Ivan Kokshaysky Subject: Re: [BUILD_FAILURE] 2.6.24-git18 build fails section type conflict psmouse-base Message-ID: <20080208133022.GA2254@cs181133002.pp.htv.fi> References: <47AC2FDB.7080104@linux.vnet.ibm.com> <20080208104851.GI7198@cs181133002.pp.htv.fi> <47AC502C.70809@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47AC502C.70809@linux.vnet.ibm.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3157 Lines: 78 On Fri, Feb 08, 2008 at 06:20:52PM +0530, Kamalesh Babulal wrote: > Adrian Bunk wrote: > > On Fri, Feb 08, 2008 at 04:02:59PM +0530, Kamalesh Babulal wrote: > >> Hi, > >> > >> The 2.6.24-git18 kernel build fails on the power machine with following message > >> > >> drivers/input/mouse/psmouse-base.c:44: error: __param_proto causes a section type conflict > >> drivers/input/mouse/psmouse-base.c:44: error: __param_proto causes a section type conflict > >> make[3]: *** [drivers/input/mouse/psmouse-base.o] Error 1 > >> make[2]: *** [drivers/input/mouse] Error 2 > >> make[1]: *** [drivers/input] Error 2 > >> make: *** [drivers] Error 2 > >> > >> this failure was reported earlier http://lkml.org/lkml/2007/9/22/64 > > > > You need the patch from [1] manually applied (due to changed context) > > and with " || defined(__powerpc__)" added for getting it compiling. > > > > @Rusty: > > Can you look at this issue? It's a modules problem on 3 architectures. > > > > cu > > Adrian > > > > [1] http://lkml.org/lkml/2007/12/27/29 > > > I tried manually applying the patch and added ||defined(__powerpc__), the above > build failure was resolved but it started failing at another place, > > CC kernel/printk.o > kernel/printk.c:568: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘static’ > make[1]: *** [kernel/printk.o] Error 1 > make: *** [kernel] Error 2 Below is what worked for me (based on Ivan's patch). The comment is wrong now, the #if's should refer to kconfig variables, and I don't know whether this patch is really the best solution. cu Adrian 1fffe660ace75bd875fc23f7b2121d7341f08464 diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index 8126e55..d17ce12 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -62,6 +62,15 @@ struct kparam_array void *elem; }; +/* On alpha and ia64 relocations to global data cannot go into read-only + sections, so 'const' makes no sense and even causes compile failures + with some compilers. */ +#if defined(__alpha__) || defined(__ia64__) || defined(__powerpc__) +#define __moduleparam_const +#else +#define __moduleparam_const const +#endif + /* This is the fundamental function for registering boot/module parameters. perm sets the visibility in sysfs: 000 means it's not there, read bits mean it's readable, write bits mean it's @@ -71,7 +80,7 @@ struct kparam_array static int __param_perm_check_##name __attribute__((unused)) = \ BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)); \ static const char __param_str_##name[] = prefix #name; \ - static struct kernel_param const __param_##name \ + static struct kernel_param __moduleparam_const __param_##name \ __used \ __attribute__ ((unused,__section__ ("__param"),aligned(sizeof(void *)))) \ = { __param_str_##name, perm, set, get, { arg } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/