Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934151AbYBHSxu (ORCPT ); Fri, 8 Feb 2008 13:53:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759702AbYBHSxn (ORCPT ); Fri, 8 Feb 2008 13:53:43 -0500 Received: from py-out-1112.google.com ([64.233.166.178]:51119 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbYBHSxm (ORCPT ); Fri, 8 Feb 2008 13:53:42 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XTyC6Iy09ovGJoY1hpvmozYR+Ov6ItLFOyzFj6dEB8vt1S1NRJnbxperWBd8sDXVlUaVCTPc22CNtR6cHXrUFKBwLgZ1EeBKayucQuETO+gkkGrlf22siv+Zj3jjJvf7VP69pjBGtOmH7STQ531rgtdEGZvP1z7NhFTA1mCEY/M= Message-ID: <386072610802081053r73aeb264m7f86d513ec7d1c6d@mail.gmail.com> Date: Sat, 9 Feb 2008 02:53:40 +0800 From: "Bryan Wu" To: "Mike Frysinger" Subject: Re: blackfin compile error Cc: "Robin Getz" , "Matt Mackall" , "Adrian Bunk" , bryan.wu@analog.com, "Linux Kernel Mailing List" , "Andrew Morton" , "David Howells" In-Reply-To: <8bd0f97a0802072125l16e3fc5cw91a92eed299f82e8@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080206151830.GI505@cs181133002.pp.htv.fi> <1202315015.17934.242.camel@cinder.waste.org> <200802061412.50675.rgetz@blackfin.uclinux.org> <8bd0f97a0802072125l16e3fc5cw91a92eed299f82e8@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2346 Lines: 63 On Feb 8, 2008 1:25 PM, Mike Frysinger wrote: > > On Feb 6, 2008 2:12 PM, Robin Getz wrote: > > On Wed 6 Feb 2008 11:23, Matt Mackall pondered: > > > On Wed, 2008-02-06 at 17:18 +0200, Adrian Bunk wrote: > > > > Commit 698dd4ba6b12e34e1e432c944c01478c0b2cd773 broke blackfin: > > > > > > > > <-- snip --> > > > > > > > > ... > > > > CC mm/vmscan.o > > > > In file included from > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/mm/vmscan.c:44: > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h: In function 'is_swap_pte': > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_none' > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/swapops.h:48: error: implicit declaration of function 'pte_present' > > > > make[2]: *** [mm/vmscan.o] Error 1 > > > > > > This suggests that no one's tried to compile -mm on Blackfin since > > > before September, I think. > > > > Or any other nommu arch's either, since looking at the include files, FRV > > (when configured as noMMU) and m68knommu does not include it either... > > > > > Is there somewhere more appropriate to move it? I can't find one. > > > Failing that, we can wrap it in CONFIG_MMU, I suppose. > > > > Or just add to the the following: > > > > ./include/asm-blackfin > > ./include/asm-frv/ (only when configured as !MMU) > > ./include/asm-h8300 > > ./include/asm-m68knommu > > ./include/asm-v850 > > > > Others seem to have it in include/asm-xxxxx/pgtable.h as #define, inline > > function, or extern. > > looks like only MMU code currently uses the function, but to keep > things nice, we may want something like: > static inline int is_swap_pte(pte_t pte) > { > #ifdef CONFIG_MMU > return !pte_none(pte) && !pte_present(pte) && !pte_file(pte); > #else > return 0; > #endif > } > > the header is also lacking an #include at the top ... > -mike > Did you submit a patch to mainline? It should be merged to fix this compiling error. Thanks a lot -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/