Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757579AbYBHVbH (ORCPT ); Fri, 8 Feb 2008 16:31:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753426AbYBHVaw (ORCPT ); Fri, 8 Feb 2008 16:30:52 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:45505 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758102AbYBHVav (ORCPT ); Fri, 8 Feb 2008 16:30:51 -0500 Date: Fri, 8 Feb 2008 22:31:01 +0100 From: Pavel Machek To: "H. Peter Anvin" Cc: Alan Stern , "Rafael J. Wysocki" , Linux-pm mailing list , kernel list Subject: Re: [linux-pm] Re: [rft] s2ram wakeup moves to .c, could fix few machines Message-ID: <20080208213101.GE12923@elf.ucw.cz> References: <20080208210004.GA12923@elf.ucw.cz> <20080208212317.GD12923@elf.ucw.cz> <47ACC942.1020308@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47ACC942.1020308@zytor.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 971 Lines: 26 On Fri 2008-02-08 13:27:30, H. Peter Anvin wrote: > Pavel Machek wrote: >> >> See arch/x86/kernel/acpi/realmode/wakeup.S (the version that was sent >> to the list). No problem there, but table stored at nonzero >> offset. Short jump at the beggining of table would fix it (ugly). >> > > Ugly, but it's the standard way to deal. We have it in the bzImage format, > too. I'd prefer to keep it as it is, there are no problems. This way, we can put debugging instructions at the first byte of wakeup code, which is somehow important. Plus, with right #defines, it should be clean enough. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/