Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761586AbYBHVmo (ORCPT ); Fri, 8 Feb 2008 16:42:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760661AbYBHVmK (ORCPT ); Fri, 8 Feb 2008 16:42:10 -0500 Received: from nf-out-0910.google.com ([64.233.182.185]:49516 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760605AbYBHVmI (ORCPT ); Fri, 8 Feb 2008 16:42:08 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=SGvjT4lxvwaMFruT7plWXbNwyI1fEYPMt3VhPDl/uBI59FiAx0pp48fP4VeXRIbXrF160DnkSKiWL1uGwEQeLEwxK6kqqPRrcZhvQZpPIXYHi0bAAm1NdVi9pIzrHOF80QhSA+2z1rilFeRULSutzg6/lKgJSWSmjnGlFbcdwl0= From: Maxim Levitsky To: Pavel Machek Subject: Re: [rft] s2ram wakeup moves to .c, could fix few machines Date: Fri, 8 Feb 2008 23:41:57 +0200 User-Agent: KMail/1.9.6 (enterprise 0.20080118.763038) Cc: "Rafael J. Wysocki" , kernel list , Linux-pm mailing list , "H. Peter Anvin" References: <20080205190600.GB11613@elf.ucw.cz> <200802072340.06138.rjw@sisk.pl> <20080208211346.GC12923@elf.ucw.cz> In-Reply-To: <20080208211346.GC12923@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802082341.58107.maximlevitsky@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2504 Lines: 76 On Friday, 8 February 2008 23:13:46 Pavel Machek wrote: > Hi! > > > > Can you post a delta against my versoin? I do not see any changes from > > > a quick glance. > > > > Appended (plus I removed two hunks, one in arch/x86/Makefile and one in > > drivers/acpi/sleep/main.c that were unrelated to the rest of the patch). > > Thanks, applied. > > > > This is probably more acceptable version of beep; but there are > > > probably even better ways to clean it... > > > > > > if (wakeup_header.realmode_flags & 4) { > > > inb(97); > > > outb(0, 0x80); > > > outb(3, 97); > > > outb(0, 0x80); > > > outb(-74, 67); > > > outb(0, 0x80); > > > outb(-119, 66); > > > outb(0, 0x80); > > > outb(15, 66); > > > } > > > > > > ...like the version that makes beep/pause/beep/pause, so that user can > > > count them. > > > > Can we move it into a separate function? > > I guess we want to use HPA's morse code ;-). > Pavel Seriously, why not... For decades BIOSes have used sound beeps to tell the user about a early problem that happened have before video is initialized. Maybe not a long messages using morse code, but at least you can have several messages to tell the user about different problems in the boot code like two short beeps for an oops 1 short beep for normal resume (so the user will know that the video is to blame) and so on. I don't know morse code, but I probably would have learn it. Once I had very nasty problem with resume, a hang, but only sometimes, and I had to play with rtc to debug it, and still I couldn't figure out what was wrong. Fortunately, this problem disappeared (was somehow fixed). For reference take a look at http://lkml.org/lkml/2007/3/17/155 I remember that I did about 1500 reboots to try to fix this. (According to hard disk's 'smart' statistics) Suggestion: the speaker usually is quite loud, thus it can be annoying to use for morse code or so. Why not to use keyboard leds for this purpose? (USB keyboard probably isn't an option, but user can always pull an old PC keyboard out of closet, and use it) Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/