Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763310AbYBHWcy (ORCPT ); Fri, 8 Feb 2008 17:32:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755499AbYBHW1N (ORCPT ); Fri, 8 Feb 2008 17:27:13 -0500 Received: from e4.ny.us.ibm.com ([32.97.182.144]:53396 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753653AbYBHW1G (ORCPT ); Fri, 8 Feb 2008 17:27:06 -0500 Subject: [RFC][PATCH 10/30] r/o bind mounts: elevate write count for vfs_rmdir() To: linux-kernel@vger.kernel.org Cc: hch@lst.de, viro@ZenIV.linux.org.uk, viro@ftp.linux.org.uk, miklos@szeredi.hu, Dave Hansen From: Dave Hansen Date: Fri, 08 Feb 2008 14:27:00 -0800 References: <20080208222641.6024A7CC@kernel> In-Reply-To: <20080208222641.6024A7CC@kernel> Message-Id: <20080208222700.ED4BBA81@kernel> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 34 Elevate the write count during the vfs_rmdir() call. Signed-off-by: Dave Hansen Acked-by: Christoph Hellwig Acked-by: Serge Hallyn Signed-off-by: Andrew Morton --- linux-2.6.git-dave/fs/namei.c | 5 +++++ 1 file changed, 5 insertions(+) diff -puN fs/namei.c~r-o-bind-mounts-do_rmdir-elevate-write-count fs/namei.c --- linux-2.6.git/fs/namei.c~r-o-bind-mounts-do_rmdir-elevate-write-count 2008-02-08 13:04:49.000000000 -0800 +++ linux-2.6.git-dave/fs/namei.c 2008-02-08 13:04:49.000000000 -0800 @@ -2187,7 +2187,12 @@ static long do_rmdir(int dfd, const char error = PTR_ERR(dentry); if (IS_ERR(dentry)) goto exit2; + error = mnt_want_write(nd.mnt); + if (error) + goto exit3; error = vfs_rmdir(nd.dentry->d_inode, dentry); + mnt_drop_write(nd.mnt); +exit3: dput(dentry); exit2: mutex_unlock(&nd.dentry->d_inode->i_mutex); _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/