Date: Sat, 9 Feb 2008 11:39:11 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@suse.de>
cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [3/3] Enable ACPI extended century handling for 32bit
 too
In-Reply-To: <20080208121455.228C31B41BB@basil.firstfloor.org>
Message-ID: <alpine.LFD.1.00.0802091136380.3145@apollo.tec.linutronix.de>
References: <20080208114.066167427@suse.de> <20080208121455.228C31B41BB@basil.firstfloor.org>
User-Agent: Alpine 1.00 (LFD 882 2007-12-20)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1249
Lines: 38

On Fri, 8 Feb 2008, Andi Kleen wrote:

> 
> Not that it matters much, see comment in the code.
> 
> Signed-off-by: Andi Kleen <ak@suse.de>
> 
> ---
>  arch/x86/kernel/rtc.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: linux/arch/x86/kernel/rtc.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/rtc.c
> +++ linux/arch/x86/kernel/rtc.c
> @@ -112,12 +112,13 @@ unsigned long mach_get_cmos_time(void)
>  	mon = CMOS_READ(RTC_MONTH);
>  	year = CMOS_READ(RTC_YEAR);
>  
> -#if defined(CONFIG_ACPI) && defined(CONFIG_X86_64)
> -	/* CHECKME: Is this really 64bit only ??? */
> +	/*
> +	 * On 32bit not strictly needed because the world ends in 2038
> +	 * and the code can handle that with the 2 digit heuristics.
> +	 */
>  	if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
>  	    acpi_gbl_FADT.century)
>  		century = CMOS_READ(acpi_gbl_FADT.century);

How does this compile with CONFIG_ACPI=n ?

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/