Message-ID: <47AEFDE9.7060405@web.de>
Date: Sun, 10 Feb 2008 14:36:41 +0100
From: Jan Kiszka <jan.kiszka@web.de>
User-Agent: Thunderbird 2.0.0.9 (X11/20070801)
MIME-Version: 1.0
To: Marcin Slusarz <marcin.slusarz@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@zip.com.au>, Thomas Gleixner <tglx@linutronix.de>,
       Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [3/6] kgdb: core
References: <20080210071331.GC3851@elte.hu> <20080210124629.GA12200@joi>
In-Reply-To: <20080210124629.GA12200@joi>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1283
Lines: 52

Marcin Slusarz wrote:
> On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote:
>> +	} else {
>> +		while (count-- > 0) {
>> +			unsigned char ch;
>> +
>> +			if (probe_kernel_address(mem, ch)) {
>> +				kgdb_may_fault = 0;
>> +				return ERR_PTR(-EINVAL);
>> +			}
>> +			mem++;
>> +			*buf++ = hexchars[ch >> 4];
>> +			*buf++ = hexchars[ch & 0xf];
> use pack_hex_byte?

Good point! kgdb introduces this helper but don't use it consequently!

>> +/*
>> + * While we find nice hex chars, build a long_val.
>> + * Return number of chars processed.
>> + */
>> +int kgdb_hex2long(char **ptr, long *long_val)
>> +{
>> +	int hex_val;
>> +	int num = 0;
>> +
>> +	*long_val = 0;
>> +
>> +	while (**ptr) {
>> +		hex_val = hex(**ptr);
>> +		if (hex_val >= 0) {
>> +			*long_val = (*long_val << 4) | hex_val;
>> +			num++;
>> +		} else
>> +			break;
>> +
>> +		(*ptr)++;
>> +	}
> if (hex_val < 0)
> 	break;
> *long_val = (*long_val << 4) | hex_val;
> num++;
> (*ptr)++;

Jep, will include this in the cleanup patch I'm currently baking.

Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/