Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752332AbYBJPzh (ORCPT ); Sun, 10 Feb 2008 10:55:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751210AbYBJPz3 (ORCPT ); Sun, 10 Feb 2008 10:55:29 -0500 Received: from mx1.redhat.com ([66.187.233.31]:52688 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbYBJPz2 (ORCPT ); Sun, 10 Feb 2008 10:55:28 -0500 Date: Sun, 10 Feb 2008 23:55:05 +0800 From: Eugene Teo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH] ftrace: remove unused tracing_sched_switch_enabled Message-ID: <20080210155505.GA16205@kernel.sg> Reply-To: Eugene Teo References: <20080210072050.GN4100@elte.hu> <20080210154923.GA15451@kernel.sg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080210154923.GA15451@kernel.sg> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1896 Lines: 61 > tracing_sched_switch_enabled isn't used anywhere. > > Signed-off-by: Eugene Teo Sorry, I forgot to remove the variable declaration. Here's a resend: tracing_sched_switch_enabled isn't used anywhere. Signed-off-by: Eugene Teo --- kernel/trace/trace.h | 1 - kernel/trace/trace_sched_switch.c | 11 +---------- 2 files changed, 1 insertions(+), 11 deletions(-) diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index ac851b2..3173a93 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -138,7 +138,6 @@ void unregister_tracer(struct tracer *type); extern unsigned long nsecs_to_usecs(unsigned long nsecs); -extern int tracing_sched_switch_enabled; extern unsigned long tracing_max_latency; extern unsigned long tracing_thresh; diff --git a/kernel/trace/trace_sched_switch.c b/kernel/trace/trace_sched_switch.c index 412c226..3e4771d 100644 --- a/kernel/trace/trace_sched_switch.c +++ b/kernel/trace/trace_sched_switch.c @@ -16,7 +16,6 @@ static struct trace_array *ctx_trace; static int __read_mostly tracer_enabled; -int __read_mostly tracing_sched_switch_enabled; static void notrace ctx_switch_func(struct task_struct *prev, struct task_struct *next) @@ -112,14 +111,6 @@ static struct tracer sched_switch_trace __read_mostly = __init static int init_sched_switch_trace(void) { - int ret; - - ret = register_tracer(&sched_switch_trace); - if (ret) - return ret; - - tracing_sched_switch_enabled = 1; - - return ret; + return register_tracer(&sched_switch_trace); } device_initcall(init_sched_switch_trace); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/