Date: Sun, 10 Feb 2008 18:02:09 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@zip.com.au>, Thomas Gleixner <tglx@linutronix.de>,
       Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [3/6] kgdb: core
Message-ID: <20080210170209.GE7088@elte.hu>
References: <20080210071331.GC3851@elte.hu> <20080210073542.GB26666@infradead.org> <20080210074352.GA7188@elte.hu> <20080210075732.GA9349@infradead.org> <20080210080225.GC7188@elte.hu> <20080210082408.GA10479@infradead.org> <20080210085735.GA13466@elte.hu> <20080210091123.GA19912@infradead.org> <20080210092728.GA19252@elte.hu> <20080210093450.GA3754@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080210093450.GA3754@infradead.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 909
Lines: 24


* Christoph Hellwig <hch@infradead.org> wrote:

> On Sun, Feb 10, 2008 at 10:27:28AM +0100, Ingo Molnar wrote:
> > > The one I noticed quickly is the __ASSEMBLY__ removal from 
> > > asm-x86/kgdb.h. [...]
> > 
> > people might want to experiment with early debug code as well and 
> > include asm-x86/kgdb.h in assembly files. So i kept that, it's 
> > sensible.
> 
> But asm-x86/kgdb.h doesn't have anythign people invoking kgdb might 
> need, it's just the arch interface to the kgdb core.  Nor does it 
> compile even with the ifdef as it already contains a C enum.

good point - i fixed this. (by following your suggestion of removing the 
_ASSEMBLY_)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/