DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=r9IpajrATzjwWatCA1ftQsqxU7AY9g3YPS87gqelGKhCFQRnCtMThSaRkzKq6QE0sbp23d4Qxo79l72rXUmNNp56/10yXuOGvmVcz3piVhB6QNQoUsH4EEN162YjTl1Brak9iGXpM5T1vayTNCnN+eo3H9cYUqYKkeElv8Yh58g=  ;
From: David Brownell <david-b@pacbell.net>
To: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
Subject: Re: [PATCH] introduce is_valid_gpio() predicate and use it in gpiolib.c
Date: Sun, 10 Feb 2008 11:18:04 -0800
User-Agent: KMail/1.9.6
Cc: linux-kernel@vger.kernel.org
References: <Pine.LNX.4.64.0802102002270.4417@axis700.grange>
In-Reply-To: <Pine.LNX.4.64.0802102002270.4417@axis700.grange>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802101118.04476.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 595
Lines: 25

I like this, but can't resist making the "Andrew Comment":

> --- a/include/asm-generic/gpio.h
> +++ b/include/asm-generic/gpio.h
> @@ -16,6 +16,8 @@
>  #define ARCH_NR_GPIOS		256
>  #endif
>  
> +#define is_valid_gpio(gpio)	((unsigned int)(gpio) < ARCH_NR_GPIOS)

Please make this an inline C function.  :)


> +
>  struct seq_file;
>  
>  /**
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/