Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755941AbYBJXcR (ORCPT ); Sun, 10 Feb 2008 18:32:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752727AbYBJXb7 (ORCPT ); Sun, 10 Feb 2008 18:31:59 -0500 Received: from smtp-out.google.com ([216.239.45.13]:11965 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbYBJXb6 (ORCPT ); Sun, 10 Feb 2008 18:31:58 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:date:from:x-x-sender:to:cc:subject:in-reply-to: message-id:references:user-agent:mime-version:content-type; b=lhkTR54hQ6j7O0QdbgJlWXu1j9CwXvzguSvcEJ6OhnTsWbVR9G+g+8akL8Vt/fpk1 tILHgmySB3N4P1zVZLssQ== Date: Sun, 10 Feb 2008 15:30:51 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrew Morton cc: Adrian Bunk , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, Robert Reif Subject: [patch] sparc: fix build In-Reply-To: <47AF7048.3060200@earthlink.net> Message-ID: References: <20080207231230.GE7198@cs181133002.pp.htv.fi> <20080210153355.GA6737@palantir8> <47AF7048.3060200@earthlink.net> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3201 Lines: 90 Fix build failures on sparc: In file included from include/linux/mm.h:39, from include/linux/memcontrol.h:24, from include/linux/swap.h:8, from include/linux/suspend.h:7, from init/do_mounts.c:6: include/asm/pgtable.h:344: warning: parameter names (without types) in function declaration include/asm/pgtable.h:345: warning: parameter names (without types) in function declaration include/asm/pgtable.h:346: error: expected '=', ',', ';', 'asm' or '__attribute__' before '___f___swp_entry' and arch/sparc/kernel/led.c: In function 'led_blink': arch/sparc/kernel/led.c:35: error: invalid use of undefined type 'struct timer_list' arch/sparc/kernel/led.c:35: error: 'jiffies' undeclared (first use in this function) arch/sparc/kernel/led.c:35: error: (Each undeclared identifier is reported only once arch/sparc/kernel/led.c:35: error: for each function it appears in.) arch/sparc/kernel/led.c:36: error: 'avenrun' undeclared (first use in this function) arch/sparc/kernel/led.c:36: error: 'FSHIFT' undeclared (first use in this function) arch/sparc/kernel/led.c:36: error: 'HZ' undeclared (first use in this function) arch/sparc/kernel/led.c:37: error: invalid use of undefined type 'struct timer_list' arch/sparc/kernel/led.c:39: error: invalid use of undefined type 'struct timer_list' arch/sparc/kernel/led.c:40: error: invalid use of undefined type 'struct timer_list' arch/sparc/kernel/led.c:42: error: implicit declaration of function 'add_timer' arch/sparc/kernel/led.c: In function 'led_write_proc': arch/sparc/kernel/led.c:70: error: implicit declaration of function 'copy_from_user' arch/sparc/kernel/led.c:84: error: implicit declaration of function 'del_timer_sync' arch/sparc/kernel/led.c: In function 'led_init': arch/sparc/kernel/led.c:109: error: implicit declaration of function 'init_timer' arch/sparc/kernel/led.c:110: error: invalid use of undefined type 'struct timer_list' Cc: Adrian Bunk Cc: Robert Reif Signed-off-by: David Rientjes --- arch/sparc/kernel/led.c | 3 ++- include/linux/memcontrol.h | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/sparc/kernel/led.c b/arch/sparc/kernel/led.c --- a/arch/sparc/kernel/led.c +++ b/arch/sparc/kernel/led.c @@ -1,8 +1,9 @@ -#include #include #include #include #include +#include +#include #include diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -20,9 +20,6 @@ #ifndef _LINUX_MEMCONTROL_H #define _LINUX_MEMCONTROL_H -#include -#include - struct mem_cgroup; struct page_cgroup; struct page; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/