Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756498AbYBKJvV (ORCPT ); Mon, 11 Feb 2008 04:51:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751874AbYBKJuX (ORCPT ); Mon, 11 Feb 2008 04:50:23 -0500 Received: from smtp-out03.alice-dsl.net ([88.44.63.5]:30318 "EHLO smtp-out03.alice-dsl.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbYBKJuU (ORCPT ); Mon, 11 Feb 2008 04:50:20 -0500 From: Andi Kleen References: <200802111050.372086035@suse.de> In-Reply-To: <200802111050.372086035@suse.de> To: tglx@linutronix.de, mingo@elte.hu, linux-kernel@vger.kernel.org Subject: [PATCH] [3/8] CPA: Fix some incorrect comments in the debug pagealloc code Message-Id: <20080211095018.6AF7E1B41CE@basil.firstfloor.org> Date: Mon, 11 Feb 2008 10:50:18 +0100 (CET) X-OriginalArrivalTime: 11 Feb 2008 09:43:57.0266 (UTC) FILETIME=[9F3D0320:01C86C92] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 32 Even with the pool cpa in debug_pagealloc can fail (e.g. consider memory hotplug) Also the code does not clear PSE anymore as the comment claims. Replace wrong comment with correct one. Signed-off-by: Andi Kleen --- arch/x86/mm/pageattr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) Index: linux/arch/x86/mm/pageattr.c =================================================================== --- linux.orig/arch/x86/mm/pageattr.c +++ linux/arch/x86/mm/pageattr.c @@ -864,10 +864,7 @@ void kernel_map_pages(struct page *page, if (!debug_pagealloc_enabled) return; - /* - * The return value is ignored - the calls cannot fail, - * large pages are disabled at boot time: - */ + /* This can fail in theory but then you're out of luck */ if (enable) __set_pages_p(page, numpages); else -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/