Message-Id: <200802111708.m1BH8q3p008073@hiauly1.hia.nrc.ca>
Subject: Re: [PATCH?][arch/parisc/kernel/pci-dma.c]      pcxl_dma_ops.alloc_noncoherent
To: 12o3l@tiscali.nl (Roel Kluin)
Date: Mon, 11 Feb 2008 12:08:51 -0500 (EST)
From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
Cc: James.Bottomley@HansenPartnership.com, kyle@parisc-linux.org,
       matthew@wil.cx, grundler@parisc-linux.org, linux-parisc@vger.kernel.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <47B07E76.9000100@tiscali.nl> from "Roel Kluin" at Feb 11, 2008 05:57:26 pm
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 943
Lines: 24

> James Bottomley wrote:
> > On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote:
> >> duplicate pa11_dma_alloc_consistent; more appropriate appears
> >> pa11_dma_alloc_noncoherent here. 
> >>
> >> Not tested, please confirm that this fix is correct
> > 
> > No, it looks completely incorrect to me.  What makes you think a pcxl
> > box has a problem with coherency?
> 
> Ok, please ignore the patch then. It just appeared suspicious to me
> that the function did exist, but the names assigned were different.

How about a comment?

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/