Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761001AbYBKTc3 (ORCPT ); Mon, 11 Feb 2008 14:32:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758895AbYBKTcR (ORCPT ); Mon, 11 Feb 2008 14:32:17 -0500 Received: from relay1.sgi.com ([192.48.171.29]:60160 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758230AbYBKTcQ (ORCPT ); Mon, 11 Feb 2008 14:32:16 -0500 Date: Mon, 11 Feb 2008 11:32:16 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: David Rientjes cc: Andrew Morton , Paul Jackson , Lee Schermerhorn , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [patch 1/4] mempolicy: convert MPOL constants to enum In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 852 Lines: 20 On Mon, 11 Feb 2008, David Rientjes wrote: > The mempolicy mode constants, MPOL_DEFAULT, MPOL_PREFERRED, MPOL_BIND, > and MPOL_INTERLEAVE, are better declared as part of an enum for type > checking. > > The policy member of struct mempolicy is also converted from type short > to type unsigned short. A negative policy does not have any legitimate > meaning, so it is possible to change its type in preparation for adding > optional mode flags later. The second paragraphs seems to indicate that such an approach does not work since we also use MPOL_xx constants to set flags in the memory policies? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/