Date: Mon, 11 Feb 2008 12:45:45 -0800 (PST)
From: Christoph Lameter <clameter@sgi.com>
To: David Rientjes <rientjes@google.com>
cc: Andrew Morton <akpm@linux-foundation.org>, Paul Jackson <pj@sgi.com>,
       Lee Schermerhorn <Lee.Schermerhorn@hp.com>, Andi Kleen <ak@suse.de>,
       linux-kernel@vger.kernel.org
Subject: Re: [patch 1/4] mempolicy: convert MPOL constants to enum
In-Reply-To: <alpine.DEB.1.00.0802111156420.17652@chino.kir.corp.google.com>
Message-ID: <Pine.LNX.4.64.0802111244140.26158@schroedinger.engr.sgi.com>
References: <alpine.DEB.1.00.0802101506130.11145@chino.kir.corp.google.com>
 <Pine.LNX.4.64.0802111131270.24563@schroedinger.engr.sgi.com>
 <alpine.DEB.1.00.0802111135090.1671@chino.kir.corp.google.com>
 <Pine.LNX.4.64.0802111146590.25590@schroedinger.engr.sgi.com>
 <alpine.DEB.1.00.0802111156420.17652@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 933
Lines: 21

On Mon, 11 Feb 2008, David Rientjes wrote:

> On Mon, 11 Feb 2008, Christoph Lameter wrote:
> 
> > Then you could follow through with the enum mempolicy thing 
> > throughtout. Why not use enum mempolicy in struct mempolicy?
> > 
> 
> Mempolicy flags, as I implemented them in patch 2 in this series, are not 
> integer constants that are enumerated starting at 0.  They are individual 
> bits that are shifted a pre-defined length and intersected with the 
> enumerated mode.  This allows both the mode and the flags to be stored in 
> the same object.

Ok. Now are you are making the same point that I did before. Lets leave 
enum out if we need to do these tricks with the upper bits.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/