Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758533AbYBKWP3 (ORCPT ); Mon, 11 Feb 2008 17:15:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753194AbYBKWPT (ORCPT ); Mon, 11 Feb 2008 17:15:19 -0500 Received: from smtp-out04.alice-dsl.net ([88.44.63.6]:10411 "EHLO smtp-out04.alice-dsl.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbYBKWPS (ORCPT ); Mon, 11 Feb 2008 17:15:18 -0500 Date: Mon, 11 Feb 2008 23:15:14 +0100 From: Andi Kleen To: Thomas Gleixner Cc: Andi Kleen , mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD Message-ID: <20080211221514.GA12592@basil.nowhere.org> References: <20080209416.271135970@suse.de> <200802110956.16004.ak@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-OriginalArrivalTime: 11 Feb 2008 22:08:53.0815 (UTC) FILETIME=[B0752470:01C86CFA] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 17 > So the warning comes a bit late :) I suspect if this was wrong before it would not have been noticed because user space hwclock would work around it. The warning certainly won't hurt. Anyways if you feel strongly about this (I don't) then drop this patch, but apply the other ones in the series. The main one I consider important is the change to the 2000 offset for 32bit to extend the 32bit lifetime. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/