Date: Mon, 11 Feb 2008 22:43:38 -0800 (PST)
Message-Id: <20080211.224338.07019204.davem@davemloft.net>
To: chris.mason@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       btrfs-devel@oss.oracle.com
Subject: Re: [ANNOUNCE] Btrfs v0.12 released
From: David Miller <davem@davemloft.net>
In-Reply-To: <200802110842.21312.chris.mason@oracle.com>
References: <200802061200.14690.chris.mason@oracle.com>
	<20080210.171257.233096646.davem@davemloft.net>
	<200802110842.21312.chris.mason@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 929
Lines: 24

From: Chris Mason <chris.mason@oracle.com>
Date: Mon, 11 Feb 2008 08:42:20 -0500

> The kernel is actually worse, because the set/get macros are more complex.  
> Some live in ctree.h like in the progs, but the nasty ones live in 
> struct-funcs.c

This is really problematic, because you've got these things called
"btrfs_item_ptr()" which really isn't a pointer, it's a relative
'unsigned long' offset cast to a pointer.  The source of this
seems to be btrfs_leaf_data().

And then those things get passed down into the SETGET functions!

Then deeper down we have terribly inconsistent things like
btrfs_item_nr_offset() and
btrfs_item_offset_nr().

Sigh... I'll see what I can do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/