Date: Tue, 12 Feb 2008 08:33:23 +0100
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>,
       Thomas Gleixner <tglx@linutronix.de>, "H. Anvin" <hpa@zytor.com>,
       Linux-tiny@selenic.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Configure out DMI scanning code
Message-ID: <20080212083323.6d579dc3@crazy>
In-Reply-To: <1202756478.28085.35.camel@cinder.waste.org>
References: <20080211175844.3358a49b@crazy>
	<1202756478.28085.35.camel@cinder.waste.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/+FEYuD.zD0iN1I0iw9eIz6l";
 protocol="application/pgp-signature"; micalg=PGP-SHA1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1903
Lines: 58

--Sig_/+FEYuD.zD0iN1I0iw9eIz6l
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Matt,

Thanks for your review.

Le Mon, 11 Feb 2008 13:01:18 -0600,
Matt Mackall <mpm@selenic.com> a =C3=A9crit :

> Looks ok. Please preserve original authorship (ie me) in some fashion
> in your description.

Andrew seems to already have picked up the patch in -mm (I received an
e-mail + x86-configurable-dmi-scanning-code.patch added to -mm tree).
If I resend a new one with proper credits, will Andrew pick it up and
replace the old version by the new version ?

> > On top of this patch, I've tested if removing the big dmi tables in
> > the code (for example in arch/x86/kernel/reboot.c) would allow to
> > make more space optimizations. However, it seems that simply
> > defining dmi_check_system() to an empty static inlined function
> > already allows gcc to optimize out the dmi tables, because there
> > are not present in the code. Is that possible, or is my
> > understanding incorrect ?
>=20
> That's possible with modern gccs, yes.

I was compiling with 4.2.3, which I suppose is a modern gcc.

Thanks,

Thomas
--=20
Thomas Petazzoni, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1500 pages!)

--Sig_/+FEYuD.zD0iN1I0iw9eIz6l
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHsUvD9lPLMJjT96cRAhXcAJsFDJ7PVFhMz23z0qu5rMI5fzKTHgCcC8gc
g80u6r8abm0KZNxUjXpkI38=
=pwbX
-----END PGP SIGNATURE-----

--Sig_/+FEYuD.zD0iN1I0iw9eIz6l--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/