Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762375AbYBLJrU (ORCPT ); Tue, 12 Feb 2008 04:47:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760156AbYBLJqh (ORCPT ); Tue, 12 Feb 2008 04:46:37 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:41485 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759529AbYBLJqf (ORCPT ); Tue, 12 Feb 2008 04:46:35 -0500 Date: Tue, 12 Feb 2008 09:46:33 +0000 From: Mark Brown To: Pete MacKay Cc: linux-kernel@vger.kernel.org, liam.girdwood@wolfsonmicro.com Subject: Re: [PATCH] Core driver for WM97xx touchscreens Message-ID: <20080212094633.GA21039@rakim.wolfsonmicro.main> Mail-Followup-To: Pete MacKay , linux-kernel@vger.kernel.org, liam.girdwood@wolfsonmicro.com References: <60949.69.30.58.166.1202774430.squirrel@architechnical.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60949.69.30.58.166.1202774430.squirrel@architechnical.net> X-Cookie: Jesus is my POSTMASTER GENERAL ... User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 17 On Mon, Feb 11, 2008 at 07:00:30PM -0500, Pete MacKay wrote: > In wm97xx-core.c, should > > +int wm97xx_resume(struct device *dev) > be static? > Also, should Yes, and in fact I had both fixes present in the development branch but had forgotten to cherry pick them over into the upstream branch - thanks for noticing, I'll respin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/