To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
       "Frank Ch. Eigler" <fche@redhat.com>,
       Roland McGrath <roland@redhat.com>,
       Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [git pull] kgdb-light -v10
From: Andi Kleen <andi@firstfloor.org>
References: <20080211015321.GA27376@one.firstfloor.org>
	<y0mhcgf4ig1.fsf@ton.toronto.redhat.com>
	<20080211162141.GA31434@elte.hu>
	<20080211171039.GA20446@one.firstfloor.org>
	<20080211230335.GA16102@elte.hu>
	<20080212100327.GA30873@one.firstfloor.org>
	<20080212112747.GA1569@elte.hu>
	<20080212121903.GA419@one.firstfloor.org>
	<20080212123839.GA15360@elte.hu>
	<20080212135027.GA1343@one.firstfloor.org>
	<20080212151611.GB3078@elte.hu>
Date: Tue, 12 Feb 2008 16:28:58 +0100
In-Reply-To: <20080212151611.GB3078@elte.hu> (Ingo Molnar's message of "Tue\, 12 Feb 2008 16\:16\:11 +0100")
Message-ID: <p733ary2nyd.fsf@bingen.suse.de>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1455
Lines: 38

Ingo Molnar <mingo@elte.hu> writes:

> * Andi Kleen <andi@firstfloor.org> wrote:
>
>> On Tue, Feb 12, 2008 at 01:38:39PM +0100, Ingo Molnar wrote:
>> > So unless i forgot about something (please yell if so), it seems to 
>> > me kgdb is now pretty ready for an upstream merge.
>> 
>> I don't know -- I have not reread everything. Please don't consider my 
>> comments as approval of the code base. [...]
>
> well, it does not take a mindreader to conclude that nothing we do could 
> possibly result in you "concluding" that kgdb would be ready for a merge 
> ;-)
>
> for me it suffices that you've run out of technical arguments and are 
> resorting to non-technical name-calling:
>
>> [...] I still think it does quite a lot of dubious and ugly things 
>> overall [...]

Let's put it like this: the amount of problems I found by reading
only about 20% of the kgdb patch justifies the statement above. Also
contrary to your repeated claims many of those are not fixed yet
as far as I can see.

Also every time I dig into something new problems raise their
head -- e.g. see earlier exchange with Jason about the likely
bogus recursion check.

Overall that's not a sign of a clean merge ready code base.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/