Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763422AbYBLUhZ (ORCPT ); Tue, 12 Feb 2008 15:37:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753242AbYBLUhK (ORCPT ); Tue, 12 Feb 2008 15:37:10 -0500 Received: from www.tglx.de ([62.245.132.106]:39188 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752238AbYBLUhJ (ORCPT ); Tue, 12 Feb 2008 15:37:09 -0500 Date: Tue, 12 Feb 2008 21:36:49 +0100 (CET) From: Thomas Gleixner To: Andi Kleen cc: Andi Kleen , mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD In-Reply-To: <20080211221514.GA12592@basil.nowhere.org> Message-ID: References: <20080209416.271135970@suse.de> <200802110956.16004.ak@suse.de> <20080211221514.GA12592@basil.nowhere.org> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 33 On Mon, 11 Feb 2008, Andi Kleen wrote: > > So the warning comes a bit late :) > > I suspect if this was wrong before it would not have been noticed > because user space hwclock would work around it. And how exaclty does it work around ? By setting the binary cmos clock with BCD values ? > The warning certainly won't hurt. It won't. > Anyways if you feel strongly about this (I don't) then drop > this patch, but apply the other ones in the series. I'm not opposing the patch, I merily asked for a removal of the never changing constant. > The main one I consider important is the change to the 2000 offset > for 32bit to extend the 32bit lifetime. Picked the whole lot up. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/