Date: Tue, 12 Feb 2008 15:16:02 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Clements <paul.clements@steeleye.com>
Cc: jens.axboe@oracle.com, randy.dunlap@oracle.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler
Message-Id: <20080212151602.f1803ef0.akpm@linux-foundation.org>
In-Reply-To: <47ADAB00.90306@steeleye.com>
References: <47AC87AE.9040408@steeleye.com>
	<20080208093341.b4d02e22.randy.dunlap@oracle.com>
	<20080208101151.935b575c.akpm@linux-foundation.org>
	<47ACA250.1010404@steeleye.com>
	<20080208204510.GD23197@kernel.dk>
	<20080208204713.GF23197@kernel.dk>
	<47ACC835.4070102@steeleye.com>
	<20080208140244.c850a5d3.akpm@linux-foundation.org>
	<47ADAB00.90306@steeleye.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 699
Lines: 19

On Sat, 09 Feb 2008 08:30:40 -0500
Paul Clements <paul.clements@steeleye.com> wrote:

> +		old_e = disk->queue->elevator;
> +		if (elevator_init(disk->queue, "deadline") == 0 ||
> +			elevator_init(disk->queue, "noop") == 0) {
> +				elevator_exit(old_e);
> +		}
>  	}

afacit elevator_init() will not trigger a request_module().  And you really
do want to trigger the request_module() here.  Perhaps the block layer
should provide a means of doing so?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/