Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760343AbYBLXgy (ORCPT ); Tue, 12 Feb 2008 18:36:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753462AbYBLXgp (ORCPT ); Tue, 12 Feb 2008 18:36:45 -0500 Received: from avexch1.qlogic.com ([198.70.193.115]:30435 "EHLO avexch1.qlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198AbYBLXgo convert rfc822-to-8bit (ORCPT ); Tue, 12 Feb 2008 18:36:44 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH resend] qla3xxx: convert byte order of constant instead ofvariable Date: Tue, 12 Feb 2008 15:36:43 -0800 Message-ID: <0BB3E5E7462EEA4295BC02D49691DC070127727B@AVEXCH1.qlogic.org> In-Reply-To: <20080210100546.GA6737@joi> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH resend] qla3xxx: convert byte order of constant instead ofvariable Thread-Index: AchrzKURqL32OmxESVmo+Lt9L4dhYgCA0RXQ From: "Ron Mercer" To: "Marcin Slusarz" , , "Linux Driver" Cc: "LKML" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1742 Lines: 58 > -----Original Message----- > From: Marcin Slusarz [mailto:marcin.slusarz@gmail.com] > Sent: Sunday, February 10, 2008 2:06 AM > To: netdev@vger.kernel.org; Linux Driver > Cc: LKML > Subject: [PATCH resend] qla3xxx: convert byte order of > constant instead ofvariable > > convert byte order of constant instead of variable > which can be done at compile time (vs run time) > > Signed-off-by: Marcin Slusarz > --- > drivers/net/qla3xxx.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c > index a6aeb9d..b7f7b22 100644 > --- a/drivers/net/qla3xxx.c > +++ b/drivers/net/qla3xxx.c > @@ -2472,8 +2472,7 @@ static int ql_send_map(struct ql3_adapter *qdev, > > if (seg_cnt == 1) { > /* Terminate the last segment. */ > - oal_entry->len = > - cpu_to_le32(le32_to_cpu(oal_entry->len) | > OAL_LAST_ENTRY); > + oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY); > } else { > oal = tx_cb->oal; > for (completed_segs=0; completed_segs completed_segs++,seg++) { > @@ -2530,8 +2529,7 @@ static int ql_send_map(struct ql3_adapter *qdev, > frag->size); > } > /* Terminate the last segment. */ > - oal_entry->len = > - cpu_to_le32(le32_to_cpu(oal_entry->len) | > OAL_LAST_ENTRY); > + oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY); > } > > return NETDEV_TX_OK; > -- > 1.5.3.7 > > Thanks Acked-by: Ron Mercer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/