Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764667AbYBMARa (ORCPT ); Tue, 12 Feb 2008 19:17:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763424AbYBMARP (ORCPT ); Tue, 12 Feb 2008 19:17:15 -0500 Received: from accolon.hansenpartnership.com ([76.243.235.52]:59895 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763342AbYBMARN (ORCPT ); Tue, 12 Feb 2008 19:17:13 -0500 Subject: Re: [PATCH] 2.6.25-rc1-git2: GDT SCSI: change drivers/scsi/gdth.c into using pci_get device From: James Bottomley To: Sergio Luis Cc: Boaz Harrosh , Achim Leubner , linux-scsi@vger.kernel.org, LKML In-Reply-To: <47B23033.1080100@larces.uece.br> References: <47B1ADCE.40202@larces.uece.br> <1202833354.3137.19.camel@localhost.localdomain> <47B1CF45.5070407@panasas.com> <47B23033.1080100@larces.uece.br> Content-Type: text/plain Date: Tue, 12 Feb 2008 18:17:03 -0600 Message-Id: <1202861823.3137.170.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 638 Lines: 19 On Tue, 2008-02-12 at 20:48 -0300, Sergio Luis wrote: > reposting an updated version of it. Please check if it's ok. Looks fine, thanks! You added an extra space at the end of while ((pdev = pci_get_device(vendor, device, pdev)) Which I fixed. Unfortunately checkpatch isn't very helpful for this driver since it uses spaces not tabs everywhere, which checkpatch really hates. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/