Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S287966AbSAHIL5>; Tue, 8 Jan 2002 03:11:57 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S287968AbSAHILh>; Tue, 8 Jan 2002 03:11:37 -0500
Received: from lacrosse.corp.redhat.com ([12.107.208.154]:27833 "EHLO
	lacrosse.corp.redhat.com") by vger.kernel.org with ESMTP
	id <S287966AbSAHIL0>; Tue, 8 Jan 2002 03:11:26 -0500
Message-ID: <3C3AA9AD.6070203@redhat.com>
Date: Tue, 08 Jan 2002 03:11:25 -0500
From: Doug Ledford <dledford@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7+) Gecko/20020103
X-Accept-Language: en-us
MIME-Version: 1.0
To: Doug Ledford <dledford@redhat.com>
CC: Thomas Gschwind <tom@infosys.tuwien.ac.at>,
        Nathan Bryant <nbryant@allegientsystems.com>,
        linux-kernel@vger.kernel.org
Subject: Re: i810_audio
In-Reply-To: <20020105031329.B6158@infosys.tuwien.ac.at> <3C3A2B5D.8070707@allegientsystems.com> <3C3A301A.2050501@redhat.com> <3C3AA6F9.5090407@redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

Doug Ledford wrote:


>> Fixes it applies except for the SiS integration:
>> * drain_dac
>>   Use interruptible_sleep_on_timeout instead of schedule_timeout.
>>   I think this is cleaner. 
> 
> 
> 
> This is fine.


Oops, this is one of the mistakes Ben pointed out to me. 
interruptible_sleep_on_timeout(wait_queue head, timeout) overwrites the wait 
queue that we've already added ourselves to.  schedule_timeout() does the 
right thing here.  (interruptible_sleep_on_timeout doesn't really buy us 
much of anything we care about either, so it's find to stay with 
schedule_timeout)




-- 

  Doug Ledford <dledford@redhat.com>  http://people.redhat.com/dledford
       Please check my web site for aic7xxx updates/answers before
                       e-mailing me about problems

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/