Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755414AbYBMC54 (ORCPT ); Tue, 12 Feb 2008 21:57:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751153AbYBMC5r (ORCPT ); Tue, 12 Feb 2008 21:57:47 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:52523 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbYBMC5q (ORCPT ); Tue, 12 Feb 2008 21:57:46 -0500 Date: Wed, 13 Feb 2008 02:57:39 +0000 From: Al Viro To: Andrew Morton Cc: David Rientjes , Adrian Bunk , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, Robert Reif Subject: Re: [patch] sparc: fix build Message-ID: <20080213025739.GO27894@ZenIV.linux.org.uk> References: <20080207231230.GE7198@cs181133002.pp.htv.fi> <20080210153355.GA6737@palantir8> <47AF7048.3060200@earthlink.net> <20080212184654.85d5ae20.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080212184654.85d5ae20.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1907 Lines: 45 On Tue, Feb 12, 2008 at 06:46:54PM -0800, Andrew Morton wrote: > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > > --- a/include/linux/memcontrol.h > > +++ b/include/linux/memcontrol.h > > @@ -20,9 +20,6 @@ > > #ifndef _LINUX_MEMCONTROL_H > > #define _LINUX_MEMCONTROL_H > > > > -#include > > -#include > > - > > struct mem_cgroup; > > struct page_cgroup; > > struct page; > > This really should have been in a separate patch and extensively tested. > > Have we checked that every file which directly or indirectly includes > memcontrol.h does not have an requirement for rcupdate.h and mm.h, where > that requirement was satisfied only via this nested inclusion? For all > architectures and for all config selections? Think not. > > Sadly, removal of nested includes is a *big* deal, and it takes quite a lot > of time to get it all shaken down. > > If we can confirm that all files (.c and .h) which include memcontrol.h > also directly include rcupdate.h and mm.h then we're _probably_ ok (modulo > ordering issues). > > Otherwise we should perhaps be taking a second look at how to fix the sparc > problem. I've run allmodconfig builds on a bunch of target, FWIW (essentially the same patch). Note that these includes are recent addition caused by added inline function that had since then become a define. So while I agree with your comments in general, in _this_ case it's pretty safe. Commit that had done it is 3062fc67dad01b1d2a15d58c709eff946389eca4 and switch to #define is 60c12b1202a60eabb1c61317e5d2678fcea9893f (BTW, that warranted mentioning in changelog of the latter). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/