Date: Wed, 13 Feb 2008 09:03:10 +0100
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org, "Shannon Nelson" <shannon.nelson@intel.com>,
       "David Brownell" <david-b@pacbell.net>, kernel@avr32linux.org,
       "Francis Moreau" <francis.moro@gmail.com>,
       "Paul Mundt" <lethal@linux-sh.org>,
       "Vladimir A. Barinov" <vbarinov@ru.mvista.com>,
       "Pierre Ossman" <drzeus-list@drzeus.cx>
Subject: Re: [RFC v3 4/7] dmaengine: Add slave DMA interface
Message-ID: <20080213090310.0c905397@dhcp-252-066.norway.atmel.com>
In-Reply-To: <e9c3a7c20802122321g7241c383ofd9a3bf6f419c7c7@mail.gmail.com>
References: <1202834638-9009-1-git-send-email-hskinnemoen@atmel.com>
	<1202834638-9009-2-git-send-email-hskinnemoen@atmel.com>
	<1202834638-9009-3-git-send-email-hskinnemoen@atmel.com>
	<1202834638-9009-4-git-send-email-hskinnemoen@atmel.com>
	<e9c3a7c20802122321g7241c383ofd9a3bf6f419c7c7@mail.gmail.com>
Organization: Atmel Norway
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 815
Lines: 23

On Wed, 13 Feb 2008 00:21:41 -0700
"Dan Williams" <dan.j.williams@intel.com> wrote:

> On Feb 12, 2008 9:43 AM, Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> [..]
> > +enum dma_slave_direction {
> > +       DMA_SLAVE_TO_MEMORY,
> > +       DMA_SLAVE_FROM_MEMORY,
> > +};
> 
> Just reuse enum dma_data_direction from the dma-mapping api.

Hmm...ok. That will add two "directions" that are a bit useless in this
context (DMA_BIDIRECTIONAL and DMA_NONE.) But I guess it's still worth
it since we can pass the direction on unchanged when syncing the
buffers.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/