Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765632AbYBMILk (ORCPT ); Wed, 13 Feb 2008 03:11:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756569AbYBMILa (ORCPT ); Wed, 13 Feb 2008 03:11:30 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:38479 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756573AbYBMIL2 (ORCPT ); Wed, 13 Feb 2008 03:11:28 -0500 Date: Wed, 13 Feb 2008 00:09:53 -0800 From: Andrew Morton To: "Ahmed S. Darwish" Cc: Joerg Platte , linux-kernel@vger.kernel.org, casey@schaufler-ca.com Subject: Re: [PATCH - BUGFIX] Smack: Check for 'struct socket' with NULL sk Message-Id: <20080213000953.dd782352.akpm@linux-foundation.org> In-Reply-To: <20080211232347.GA3635@ubuntu> References: <200802111926.03067.jplatte@naasa.net> <20080211232347.GA3635@ubuntu> X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 502 Lines: 14 On Tue, 12 Feb 2008 01:23:47 +0200 "Ahmed S. Darwish" wrote: > + BUG_ON(sk == NULL); > + ssp = sk->sk_security; I'll remove the BUG_ON - the oops on the next line will provide us with just the same information. Thanks for the fix. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/