Message-ID: <47B2CDD1.1070406@tiscali.nl>
Date: Wed, 13 Feb 2008 12:00:33 +0100
From: Roel Kluin <12o3l@tiscali.nl>
User-Agent: Thunderbird 2.0.0.9 (X11/20071031)
MIME-Version: 1.0
To: thomas@winischhofer.net, lkml <linux-kernel@vger.kernel.org>
Subject: [drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_661 not evaluated
 twice
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 714
Lines: 14

Not sure whether this is important, but in drivers/video/sis/init301.c:1557:

  if((SiS_Pr->ChipType >= SIS_661) || (SiS_Pr->SiS_ROMNew)) {
     SiS_Pr->SiS_LCDTypeInfo = (SiS_GetReg(SiS_Pr->SiS_P3d4,0x39) & 0x7c) >> 2;
  } else if((SiS_Pr->ChipType < SIS_315H) || (SiS_Pr->ChipType >= SIS_661)) {
     SiS_Pr->SiS_LCDTypeInfo = temp >> 4;

note the duplicate test for 'SiS_Pr->ChipType >= SIS_661'
if it was true in the first test, the second test won't be evaluated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/