Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932142AbYBML0e (ORCPT ); Wed, 13 Feb 2008 06:26:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757629AbYBML0L (ORCPT ); Wed, 13 Feb 2008 06:26:11 -0500 Received: from mail.suse.de ([195.135.220.2]:50952 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757283AbYBML0J (ORCPT ); Wed, 13 Feb 2008 06:26:09 -0500 Message-ID: <47B2D41E.6040908@suse.de> Date: Wed, 13 Feb 2008 12:27:26 +0100 From: Andi Kleen User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Thomas Gleixner Cc: ying.huang@intel.com, mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [1/2] CPA: Fix set_memory_x for ioremap v2 References: <20080212153.888987414@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 25 > The so-called "significant restructuring" took a mere 2 hours, > which is probably less than the time consumed in this thread. Hmm, it doesn't do what I meant and I don't think you solved the problem. You still check against the vaddrs which won't work for ioremaps or fixmap (and thus not fix the EFI cases) What I meant with restructuring is calling lookup_address() early, get the physical address from the PTE, then check that against the alias ranges in physical. That would actually work for fixmaps and ioremaps and all other mappings too. I'm sure it can be all done, but for me it to submit such a change would likely require weeks of thread like this so I'm not trying. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/