Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763283AbYBMNGo (ORCPT ); Wed, 13 Feb 2008 08:06:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757077AbYBMNGW (ORCPT ); Wed, 13 Feb 2008 08:06:22 -0500 Received: from ns.suse.de ([195.135.220.2]:41365 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755979AbYBMNGV (ORCPT ); Wed, 13 Feb 2008 08:06:21 -0500 Date: Wed, 13 Feb 2008 14:06:20 +0100 Message-ID: From: Takashi Iwai To: Matej Laitl Cc: alsa-devel , LKML Subject: Re: [ALSA] HDA: no sound in headphone-out caused by commit f889fa91ad47e (2.6.25-rc1 regression) In-Reply-To: <200802131305.48471.strohel@gmail.com> References: <200802112158.41989.strohel@gmail.com> <200802122357.46309.strohel@gmail.com> <200802131305.48471.strohel@gmail.com> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1865 Lines: 50 At Wed, 13 Feb 2008 13:05:48 +0100, Matej Laitl wrote: > > On Wednesday 13 of February 2008 11:59:58 Takashi Iwai wrote: > > > Now I just found that the new "Speaker" switch forgets it's value from > > > time to time, ie. it's muted, you go and have lunch, and when you get > > > back and start the music, it's unmuted. It is probably related to > > > aggressive hda-codec powersaving, which I have enabled and set to 20 > > > secs. > > > > Hm, does the patch below have any influence? > > If the problem still persists, please take alsa-info.sh snapshots > > before and after power-saving. > > This patch did not have any effect. (i haven't tested suspend-to-ram) > > alsa-info before powersaving (speaker silent, mixer says: Speaker=MM): > http://pastebin.ca/902330 > > alsa-info after powersaving (speaker loud, mixer says: Speaker=MM): > http://pastebin.ca/902332 Oh, it's my thinko. The init routine shouldn't update the amp cache. The patch below should fix this problem. Actually it reverts the code to my first patch. Takashi --- diff -r f4f3c5e8931a pci/hda/patch_realtek.c --- a/pci/hda/patch_realtek.c Tue Feb 12 18:37:26 2008 +0100 +++ b/pci/hda/patch_realtek.c Wed Feb 13 14:06:44 2008 +0100 @@ -3489,7 +3489,8 @@ static void alc_set_pin_output(struct hd snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_PIN_WIDGET_CONTROL, pin_type); /* unmute pin */ - snd_hda_codec_amp_stereo(codec, nid, HDA_OUTPUT, 0, 0xff, 0x00); + snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_AMP_GAIN_MUTE, + AMP_OUT_UNMUTE); } static void alc880_auto_set_output_and_unmute(struct hda_codec *codec, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/