Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761424AbYBMOyW (ORCPT ); Wed, 13 Feb 2008 09:54:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753929AbYBMOyO (ORCPT ); Wed, 13 Feb 2008 09:54:14 -0500 Received: from wx-out-0506.google.com ([66.249.82.225]:34641 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbYBMOyN (ORCPT ); Wed, 13 Feb 2008 09:54:13 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=WspYYyA4tm0KfzD+DSA8Rsx5hfzGPkz+lydkvWZNzkMv2Hc0lhE9LJt0weOLGYzVba+EG4zkC3n4VFWA+ATHT1YJtc7/+GrOJNb2Q/jmxNjCkpCbsmcVZHVk+5j0N7iKOOxuC2oiuL5xbpHNvXqVa5d096mJA+1kvVPPobRe/EY= Message-ID: <84144f020802130654w51901fb1hf29d39ba86d87414@mail.gmail.com> Date: Wed, 13 Feb 2008 16:54:11 +0200 From: "Pekka Enberg" To: "linux-os (Dick Johnson)" Subject: Re: [PATCH] fs/coda: remove static inline forward declarations Cc: "=?ISO-8859-1?Q?Ilpo_J=E4rvinen?=" , jaharkes@cs.cmu.edu, "Andrew Morton" , LKML In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Google-Sender-Auth: 95f06d6f4fee662e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 14 On Feb 13, 2008 3:43 PM, linux-os (Dick Johnson) wrote: > You should not remove things just because you don't think they > are necessary. They do no harm and removing them can cause > code checking tools to issue diagnostic messages. Err, no, Ilpo's patch looks good and the redundant declarations should be removed. Andrew, please queue up this patch. Reviewed-by: Pekka Enberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/