Date: Wed, 13 Feb 2008 15:55:20 +0100
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Nur Hussein <nurhussein@gmail.com>
Cc: linux-kernel@vger.kernel.org, randy.dunlap@oracle.com, arjan@infradead.org,
       akpm@linux-foundation.org, mingo@elte.hu, a.p.zijlstra@chello.nl,
       kyle@parisc-linux.org, schwidefsky@de.ibm.com, lethal@linux-sh.org
Subject: Re: Taint kernel after WARN_ON(condition) v2
Message-ID: <20080213155520.681e7c06@dhcp-252-066.norway.atmel.com>
In-Reply-To: <20080213142740.GA4895@gandalf.middleearth>
References: <20080213142740.GA4895@gandalf.middleearth>
Organization: Atmel Norway
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1190
Lines: 41

On Wed, 13 Feb 2008 22:27:40 +0800
Nur Hussein <nurhussein@gmail.com> wrote:

> This does not work on architectures where WARN_ON has its own definition. 
> These archs are:
> 	1. s390
> 	2. superh
> 	3. avr32
> 	4. parisc

Hmm. Relying on the generic code in lib/bug.c qualifies as "own
definition" these days? I think the patch below should take care of all
four...unless I've misunderstood something.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>

diff --git a/lib/bug.c b/lib/bug.c
index 530f38f..0d67419 100644
--- a/lib/bug.c
+++ b/lib/bug.c
@@ -35,6 +35,7 @@
 
     Jeremy Fitzhardinge <jeremy@goop.org> 2006
  */
+#include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/module.h>
 #include <linux/bug.h>
@@ -149,6 +150,7 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
 			       (void *)bugaddr);
 
 		show_regs(regs);
+		add_taint(TAINT_WARN);
 		return BUG_TRAP_TYPE_WARN;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/