Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932444AbYBMTHn (ORCPT ); Wed, 13 Feb 2008 14:07:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755901AbYBMTHe (ORCPT ); Wed, 13 Feb 2008 14:07:34 -0500 Received: from ti-out-0910.google.com ([209.85.142.190]:51042 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753974AbYBMTHd (ORCPT ); Wed, 13 Feb 2008 14:07:33 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=UWhmi8Ama+YVwIaw9ulDQUibmzZkTsVJp9xjPcsaHdp+Ojk46YKRyQl2fSfETOavuYAI5AV075O5QDeTUwqaE8bIDyUL8gjjLezqmt9I43gdmKkLC68vgGnqgyHstQplh9bRym5QL3BFVdo1jU0UaEHv0bWFNIwEYt9+jqEhCd8= Message-ID: Date: Wed, 13 Feb 2008 12:07:26 -0700 From: "Dan Williams" To: "Haavard Skinnemoen" Subject: Re: [RFC v3 4/7] dmaengine: Add slave DMA interface Cc: linux-kernel@vger.kernel.org, "Shannon Nelson" , "David Brownell" , kernel@avr32linux.org, "Francis Moreau" , "Paul Mundt" , "Vladimir A. Barinov" , "Pierre Ossman" In-Reply-To: <1202834638-9009-4-git-send-email-hskinnemoen@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1202834638-9009-1-git-send-email-hskinnemoen@atmel.com> <1202834638-9009-2-git-send-email-hskinnemoen@atmel.com> <1202834638-9009-3-git-send-email-hskinnemoen@atmel.com> <1202834638-9009-4-git-send-email-hskinnemoen@atmel.com> X-Google-Sender-Auth: 2db55569951c5312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 21 On Feb 12, 2008 9:43 AM, Haavard Skinnemoen wrote: [..] > /** > + * struct dma_slave_descriptor - extended DMA descriptor for slave DMA > + * @async_tx: async transaction descriptor > + * @client_node: for use by the client, for example when operating on > + * scatterlists. > + */ > +struct dma_slave_descriptor { > + struct dma_async_tx_descriptor txd; > + struct list_head client_node; > +}; Can you explain a bit why client_node is needed? I do not think we need dma_slave_descriptor if dma_unmap data / control is added to dma_async_tx_descriptor. Hmm? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/