Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934515AbYBMVx0 (ORCPT ); Wed, 13 Feb 2008 16:53:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764738AbYBMVb4 (ORCPT ); Wed, 13 Feb 2008 16:31:56 -0500 Received: from smtp4.pp.htv.fi ([213.243.153.38]:50895 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759458AbYBMVbg (ORCPT ); Wed, 13 Feb 2008 16:31:36 -0500 Date: Wed, 13 Feb 2008 23:31:20 +0200 From: Adrian Bunk To: linux-kernel@vger.kernel.org Cc: Bryan Wu Subject: [2.6 patch] make BINFMT_FLAT a bool Message-ID: <20080213213120.GY3383@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 59 I have not yet seen anyone saying he has a reasonable use case for using BINFMT_FLAT modular on his embedded device. Considering that fs/binfmt_flat.c even lacks a MODULE_LICENSE() I really doubt there is any, and this patch therefore makes BINFMT_FLAT a bool. Signed-off-by: Adrian Bunk Acked-by: Bryan Wu --- This patch has been sent on: - 20 Jan 2008 - 1 Jan 2008 fs/Kconfig.binfmt | 2 +- fs/binfmt_flat.c | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) 5437fb7517380d1b93dde3c09dbd3a2efaf276c3 diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt index d4fc609..c16a16c 100644 --- a/fs/Kconfig.binfmt +++ b/fs/Kconfig.binfmt @@ -37,7 +37,7 @@ config BINFMT_ELF_FDPIC It is also possible to run FDPIC ELF binaries on MMU linux also. config BINFMT_FLAT - tristate "Kernel support for flat binaries" + bool "Kernel support for flat binaries" depends on !MMU help Support uClinux FLAT format binaries. diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 33764fd..274d723 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -933,14 +933,8 @@ static int __init init_flat_binfmt(void) return register_binfmt(&flat_format); } -static void __exit exit_flat_binfmt(void) -{ - unregister_binfmt(&flat_format); -} - /****************************************************************************/ core_initcall(init_flat_binfmt); -module_exit(exit_flat_binfmt); /****************************************************************************/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/