From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org, benh@kernel.crashing.org
Subject: Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports
Date: Thu, 14 Feb 2008 00:07:37 +0100
User-Agent: KMail/1.9.6 (enterprise 0.20080118.763038)
Cc: Christian Krafft <krafft@de.ibm.com>, parabelboi@bopserverein.de,
       linux-kernel@vger.kernel.org
References: <20080213182800.5c6940a8@de.ibm.com> <20080213183506.7f3e3145@de.ibm.com> <1202935374.7296.44.camel@pasglop>
In-Reply-To: <1202935374.7296.44.camel@pasglop>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802140007.38407.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1074
Lines: 24

On Wednesday 13 February 2008, Benjamin Herrenschmidt wrote:
> On Wed, 2008-02-13 at 18:35 +0100, Christian Krafft wrote:
> > sensors_detect crashes kernel on PowerPC, as it pokes directly to memory.
> > This patch adds a check_legacy_ioports to read_port and write_port.
> > It will now return ENXIO, instead of oopsing.
> > 
> > Signed-off-by: Christian Krafft <krafft@de.ibm.com>
> 
> The problem is that this prevents using /proc/ioports to access PCI
> IO space, which might be useful.
> 
> I hate that sensors_detect.. or for that matter any other userland code
> that pokes random ports like that. It should die.

What kind of Oops do you get? Is it because the ioport area is not
ioremapped at all or do you get a machine check? If there is no
mapping, we could possibly change inb and outb do deal with that.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/