Date: Thu, 14 Feb 2008 06:50:52 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@kernel.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>, Andi Kleen <ak@suse.de>,
       Thomas Gleixner <tglx@linutronix.de>, hpa@zytor.com,
       linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] x86: make dump_pagetable() static
Message-ID: <20080214055052.GA29509@elte.hu>
References: <20080213213131.GA3383@cs181133002.pp.htv.fi> <1202941667.18204.14.camel@brick> <20080213223621.GC12383@cs181133002.pp.htv.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080213223621.GC12383@cs181133002.pp.htv.fi>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1202
Lines: 32


* Adrian Bunk <bunk@kernel.org> wrote:

> On Wed, Feb 13, 2008 at 02:27:47PM -0800, Harvey Harrison wrote:
> > On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote:
> > > dump_pagetable() can now become static.
> > > 
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>

thanks, applied.

> > I believe Andi Kleen wanted this kept global to make it easy to use 
> > when adding debugging code elsewhere.
> 
> That's not a reason as long as his code isn't in the tree (and he 
> anyway has to patch the kernel for using it).

correct. There's also a new CONFIG_X86_PTDUMP=y pagetable dumping debug 
feature now in x86.git#mm that produces much nicer output.

Arjan: i it might be nice to make the new pagetable dumper triggerable 
from a SysRq - could you try the kernel/time/timer_list.c's SEQ_printf() 
trick to make the dumping dual-purpose? [so that it printk()'s if it 
should dump to the console and seq_printf()'s if it should dump via 
/proc]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/