Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763077AbYBNODV (ORCPT ); Thu, 14 Feb 2008 09:03:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751722AbYBNODM (ORCPT ); Thu, 14 Feb 2008 09:03:12 -0500 Received: from relais.videotron.ca ([24.201.245.36]:15475 "EHLO relais.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbYBNODL (ORCPT ); Thu, 14 Feb 2008 09:03:11 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: TEXT/PLAIN; charset=US-ASCII Date: Thu, 14 Feb 2008 09:03:09 -0500 (EST) From: Nicolas Pitre X-X-Sender: nico@xanadu.home To: Kevin Hilman Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.24-rt1] SMC91x: Use special_lock when CONFIG_PREEMPT_[HARD|SOFT]IRQS In-reply-to: <1202952946-10511-1-git-send-email-khilman@mvista.com> Message-id: References: <1202952946-10511-1-git-send-email-khilman@mvista.com> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 45 On Wed, 13 Feb 2008, Kevin Hilman wrote: > The smc_special_locks should also be used when either softIRQs or hard > IRQs are preempted which may lead to the same problems as under SMP. > > Signed-off-by: Kevin Hilman Acked-by: Nicolas Pitre > > --- > drivers/net/smc91x.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c > index f198c49..be62616 100644 > --- a/drivers/net/smc91x.c > +++ b/drivers/net/smc91x.c > @@ -530,7 +530,8 @@ static inline void smc_rcv(struct net_device *dev) > } > } > > -#ifdef CONFIG_SMP > +#if defined(CONFIG_SMP) || \ > + defined(CONFIG_PREEMPT_SOFTIRQS) || defined(CONFIG_PREEMPT_HARDIRQS) > /* > * On SMP we have the following problem: > * > -- > 1.5.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/