Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759328AbYBNPzz (ORCPT ); Thu, 14 Feb 2008 10:55:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753314AbYBNPzr (ORCPT ); Thu, 14 Feb 2008 10:55:47 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:56310 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753256AbYBNPzp (ORCPT ); Thu, 14 Feb 2008 10:55:45 -0500 Date: Thu, 14 Feb 2008 15:55:43 +0000 From: Mark Brown To: Dmitry Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Graeme Gregory , Mike Arthur , Stanley Cai , Rodolfo Giometti , Russell King , Pete MacKay , Marc Kleine-Budde , Ian Molton , Vincent Sanders , Andrew Zabolotny Subject: Re: [PATCH 1/6] Core driver for WM97xx touchscreens Message-ID: <20080214155542.GA10009@rakim.wolfsonmicro.main> Mail-Followup-To: Dmitry , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood , Graeme Gregory , Mike Arthur , Stanley Cai , Rodolfo Giometti , Russell King , Pete MacKay , Marc Kleine-Budde , Ian Molton , Vincent Sanders , Andrew Zabolotny References: <20080213140648.GD31617@rakim.wolfsonmicro.main> <1202912042-2631-1-git-send-email-broonie@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: Sight is a faculty User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 15 On Thu, Feb 14, 2008 at 06:10:19PM +0300, Dmitry wrote: > 2008/2/13, Mark Brown : > > +#define WM97XX_ADCSEL_X 0x1000 /* x coord measurement */ > > +#define WM97XX_ADCSEL_Y 0x2000 /* y coord measurement */ > > +#define WM97XX_ADCSEL_PRES 0x3000 /* pressure measurement */ > shouldn't this be 0x4000 ? No, these are an enumeration on the chip rather than a bitmask. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/