Date: Thu, 14 Feb 2008 12:26:59 -0800 (PST)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
cc: Robert Hancock <hancockr@shaw.ca>,
       Andrew Morton <akpm@linux-foundation.org>, avuton@gmail.com,
       yakui.zhao@intel.com, shaohua.li@intel.com, trenn@suse.de,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       alsa-devel@alsa-project.org
Subject: Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0
 sound card
In-Reply-To: <200802141307.59120.bjorn.helgaas@hp.com>
Message-ID: <alpine.LFD.1.00.0802141226010.6110@woody.linux-foundation.org>
References: <fa.Kmpf0B4W44W1VefIME7+BnfUouY@ifi.uio.no> <200802141151.40396.bjorn.helgaas@hp.com> <alpine.LFD.1.00.0802141141470.6110@woody.linux-foundation.org> <200802141307.59120.bjorn.helgaas@hp.com>
User-Agent: Alpine 1.00 (LFD 882 2007-12-20)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 973
Lines: 27


On Thu, 14 Feb 2008, Bjorn Helgaas wrote:

> On Thursday 14 February 2008 12:42:52 pm Linus Torvalds wrote:
> > 
> > It *shouldn't* fail.
> > 
> > Things should fail only when two different drivers have requested the same 
> > region. NOT when something tells the system that a region _exists_.
> 
> The sound driver doesn't fail because two different drivers have
> requested the same region; it fails because PNP told us a region
> exists, and the sound region crosses the edge of the PNP region.

Right, and that was a bug.

It *shouldn't* fail. The PnP resource should be inserted _after_ the 
PCI region has been inserted, and _that_ should fail, since the PnP region 
is crap and cannot be inserted "half-way".

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/