Subject: Re: [PATCH] Add MS_BIND_FLAGS mount flag
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: menage@google.com, viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
In-Reply-To: <E1JPmPw-0003au-SF@pomaz-ex.szeredi.hu>
References: <47B283EB.8070209@google.com>
	 <E1JPZUb-00013Z-0U@pomaz-ex.szeredi.hu>
	 <6599ad830802140719l270d6fdfyd6d17806eda12a8d@mail.gmail.com>
	 <E1JPgYm-0002dm-IX@pomaz-ex.szeredi.hu>
	 <1203006419.8343.48.camel@heimdal.trondhjem.org>
	 <E1JPi3u-0002rp-Nz@pomaz-ex.szeredi.hu>
	 <1203016675.18369.21.camel@heimdal.trondhjem.org>
	 <E1JPmPw-0003au-SF@pomaz-ex.szeredi.hu>
Content-Type: text/plain
Date: Thu, 14 Feb 2008 18:33:02 -0500
Message-Id: <1203031982.18860.60.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1010
Lines: 28


On Thu, 2008-02-14 at 23:18 +0100, Miklos Szeredi wrote:

> I understand perfectly that this is what you want to do.  And I'm
> saying that the following code snippet should do exactly the same,
> without having to add a new syscall:
> 
> 	char tmpbuf[64];
> 	sprintf(tmpbuf, "/proc/self/fd/%i", fd);
> 	mount(dev_name, tmpbuf, type, flags, data);
> 
> [ You could actually try to read people's responses, instead of
> immediately assuming they don't understand :-/ ]

I did read your reply, but the follow-link magic that is performed in
proc_fd_link() wasn't immediately obvious to someone who is unfamiliar
with that code. I understand where you're coming from now.

Anyhow, that does indeed look as if it will do what is needed for the
automounter.

   Trond

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/