Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934349AbYBOAA1 (ORCPT ); Thu, 14 Feb 2008 19:00:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758452AbYBOAAP (ORCPT ); Thu, 14 Feb 2008 19:00:15 -0500 Received: from smtp4.pp.htv.fi ([213.243.153.38]:59966 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756047AbYBOAAO (ORCPT ); Thu, 14 Feb 2008 19:00:14 -0500 Date: Fri, 15 Feb 2008 01:59:52 +0200 From: Adrian Bunk To: Harvey Harrison Cc: Andrew Morton , LKML Subject: Re: [PATCH] ubi: fix sparse errors in ubi.h Message-ID: <20080214235952.GI23227@cs181133002.pp.htv.fi> References: <1203025995.5601.0.camel@brick> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1203025995.5601.0.camel@brick> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 36 On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote: > In C, signed 1-bit bitfields can only take the values 0 and -1, only > 0 and 1 are ever assigned in current code. Make them unsigned > bitfields. > > Fixes the (repeated) sparse errors: > drivers/mtd/ubi/ubi.h:220:15: error: dubious one-bit signed bitfield > drivers/mtd/ubi/ubi.h:221:17: error: dubious one-bit signed bitfield > drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield > drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield > drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield > > Signed-off-by: Harvey Harrison > --- > Sorry, not sure who to CC on this. >... $ grep UBI MAINTAINERS UNSORTED BLOCK IMAGES (UBI) $ cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/