Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758293AbYBOF3W (ORCPT ); Fri, 15 Feb 2008 00:29:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751508AbYBOF3O (ORCPT ); Fri, 15 Feb 2008 00:29:14 -0500 Received: from hs-out-0708.google.com ([64.233.178.243]:54349 "EHLO hs-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbYBOF3N (ORCPT ); Fri, 15 Feb 2008 00:29:13 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=xVSbSEZOjuSeAeMzqVWhFTlTozeoi6QopMMP7aMvqY3FMaqFYf0/3ED4oYPgEJRsAvWqL+rpNvC6uJCZieLJMDOruZI1xWiPkYjvxcAVElFs+NZp2cgilIu6RoZNI+IGCRLt4/Om/tLwsFNnPJaIvC7AVzbBPdCr+PyNE8MWPeE= Message-ID: Date: Thu, 14 Feb 2008 22:29:11 -0700 From: "Dan Williams" To: "Kumar Gala" Subject: Re: dma engine drivers for 2.6.25? Cc: "LKML Kernel" , "Andrew Morton" , "Zhang Wei" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Google-Sender-Auth: cdd130b799cf2ce6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 36 On Thu, Feb 14, 2008 at 8:44 PM, Kumar Gala wrote: > > On Feb 14, 2008, at 12:14 PM, Dan Williams wrote: > > > On Wed, Feb 13, 2008 at 8:52 PM, Kumar Gala > > wrote: > >> Dan, > >> > >> What's going on with the dma engine drivers for 2.6.25? We had a > >> Freescale dma driver from Zhang Wei queued up but seems to have been > >> lost. > > > > I pulled it into my tree and am holding it until Zhang has an > > opportunity to address the pending review comments [1]. I also did > > not feel comfortable pushing it to Linus without a PPC maintainer's > > Acked-by/Reviewed-by. > > > > I have attached the version I am carrying. > > What issues are still open. I was under the belief that Zhang had > resolved all the issues. > The high priority review item is that the driver performs operation completion callbacks in hardirq context. Clients of the API assume that callbacks will happen in softirq context. Of lesser concern is the use of GFP_ATOMIC in fsl_dma_alloc_descriptor. Other drivers preallocate a small pool of descriptors. Regards, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/