From: Frans Pop <elendil@planet.nl>
To: Greg KH <gregkh@suse.de>
Subject: Re: [2.6.25-rc1] System no longer powers off after shutdown
Date: Fri, 15 Feb 2008 11:19:20 +0100
User-Agent: KMail/1.9.7
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
References: <200802111623.38478.elendil@planet.nl> <86802c440802141538m44d64b6as827426174874979d@mail.gmail.com> <20080215065746.GA8916@suse.de>
In-Reply-To: <20080215065746.GA8916@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802151119.23325.elendil@planet.nl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1158
Lines: 37

On Friday 15 February 2008, Greg KH wrote:
> I swear someone sent this patch in before.  Can you try this one below,
> there seems to be an imbalance with kobject_get and _put.

I did remember seeing this patch before [1] and can confirm that it does 
indeed fix the issue: with this patch applied to 2.6.25 git head my system 
powers off correctly.

[1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.

> ---
>  drivers/cpufreq/cpufreq.c |    8 --------
>  1 file changed, 8 deletions(-)
>
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
>  	}
>  #endif
>
> -
> -	if (!kobject_get(&data->kobj)) {
> -		spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
> -		cpufreq_debug_enable_ratelimit();
> -		unlock_policy_rwsem_write(cpu);
> -		return -EFAULT;
> -	}
> -
>  #ifdef CONFIG_SMP
>
>  #ifdef CONFIG_HOTPLUG_CPU

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/